[systemd-devel] [PATCH] option to ignore ENOMEDIUM in blkid

[Hans Scholze]

On Tue, Feb 17, 2015 at 12:06 AM, Oliver Neukum <oneukum at suse.de> wrote:
>
> On Mon, 2015-02-16 at 14:52 -0800, Hans Scholze wrote:
> > Hi,
> >
> >
> > I'm not sure if this is considered a problem but I noticed some
> > spurious error messages during boot.  The source appears to be:
> >
> >
> > 1. a USB media card reader is plugged in at boot
> > 2. the device node exists regardless of whether a card is present
> > (expected)
> > 3. line 70 of 60-persistent-storage.rules (KERNEL!="sr*",
> > IMPORT{builtin}="blkid") attempts blkid on the device with no card
> > present
> > 4. the open() call in builtin_blkid() in udev-builtin-blkid.c fails
> > resulting in an "error: /dev/sdd: No medium found" message printed to
> > stderr
> >
> That seems to be the error. You cannot guarantee that blkid will never
> see this error if the drive has removable media. It should have an
> option for silently failing in these cases.

Sounds like a good idea to me but I am not too familiar with the code.
How about this?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-option-to-silently-ignore-ENOMEDIUM-to-udev-buil.patch
Type: text/x-patch
Size: 2302 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20150218/6ddb0d09/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Ignore-ENOMEDIUM-in-blkidduring-persistent-storage-n.patch
Type: text/x-patch
Size: 982 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20150218/6ddb0d09/attachment-0003.bin>