[systemd-devel] [systemd] Add dbxtool to 90-default.present.

[Peter Jones]

On Fri, Feb 20, 2015 at 04:01:26PM +0100, Lennart Poettering wrote:
> Heya,
> 
> On 18.02.2015 19:14, Peter Jones wrote:
> 
> >Description=Secure Boot DBX updater
> 
> It would be good to mention what "DBX" is.
> 
> >RequiresMountsFor=/usr/bin/ /usr/share/dbxtool/
> 
> This is unnecessary. Please remove. /usr must be on a single mount point,
> and has to be mounted before the transition from the initrd into the host
> OS, hence this is unnecessary.
>
> >After=sys-firmware-efi-efivars.mount
> >Requires=sys-firmware-efi-efivars.mount
> 
> This is wrong. efivarfs is an API file system that is not exposed as .mount
> unit. It's always mounted by PID 1 early on, like /proc. Please remove.

Okay, that's definitely useful info.  Which piece of documentation
should I have read to figure that out?

> >ConditionPathExists=/sys/firmware/efi/efivars
> >
> >[Install]
> >WantedBy=basic.target
> 
> basic.target is an early-boot target. If you want your service to run in
> early boot, you need to set DEfaultDependencies=no, because your service is
> otherwise started in late boot.

Alright; as I said on my mail before this one (that I assume you have
not received yet when you wrote this), I'm not actually certain I care
about that /at all/.  What defines "early" versus "late" boot?  I
suspect I don't care and I could make this "Wants=" instead?

To be honest The only thing I care about is that it gets run a) after
the efivars mount, and b) before shutdown happens under normal cases.
That is, I don't *really* care if it doesn't get run if the user is
pounding on ctrl-alt-del the moment systemd starts.

> >[Service]
> >Type=simple
> 
> This is the implied default, and hence redundant. Please remove.

Done.  Thanks for the help; the documentation is useful but there's a
lot to take in.  (Not a complaint.)

-- 
        Peter