[systemd-devel] [systemd] Add dbxtool to 90-default.present.

[Lennart Poettering]

On Fri, 20.02.15 10:18, Peter Jones (pjones at redhat.com) wrote:

> -------------------------------------------------------
> [Unit]
> Description=Secure Boot DBX updater
> After=local-fs.target

THis is a late boot service now, given that you do not use
DefaultDependencies=no. Late boot services are implicitly ordered
after local-fs.target, hence this explicit dependency can be
dropped. Pleas remove.

(See the ASCII flow chart in bootup(7) for some details on th ordering)

> After=sys-firmware-efi-efivars.mount

There's no such .mount unit, this API fs is mounted implicitly by PID
1. Please remove.

> ConditionPathExists=/sys/firmware/efi/efivars
> 
> [Install]
> WantedBy=basic.target

Please use WantedBy=multi-user.target, since this is supposed to be a
late boot service, as I understood.

> 
> [Service]
> Type=simple

Implied default, redundant, please remove. 

> RemainAfterExit=yes
> ExecStart=/usr/bin/dbxtool -a /usr/share/dbxtool/
> -------------------------------------------------------
> 
> Would RequiresMountsFor=/sys/firmware/efi/efivars be better?  Will it
> actually work, or will it just put it after /sys is mounted?  All
> suggestions welcome.

No, that would not be beneficial.

Lennart

-- 
Lennart Poettering, Red Hat