[systemd-devel] [PATCH] configure: turn off -Wlogical-not-parentheses

[Shawn Landden]

On Tue, Feb 24, 2015 at 9:33 AM, David Herrmann <dh.herrmann at gmail.com>
wrote:

> Hi
>
> On Mon, Feb 16, 2015 at 11:02 PM, Shawn Landden <shawn at churchofgit.com>
> wrote:
> > Introduced in gcc-5
> >
> > These errors are really annoying. I can get behind clarification of
> nested ifs,
> > but this is overkill.
> > ---
> >  configure.ac | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/configure.ac b/configure.ac
> > index 97a29d6..e646db7 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -187,6 +187,7 @@ CC_CHECK_FLAGS_APPEND([with_cflags], [CFLAGS], [\
> >          -Wno-unused-parameter \
> >          -Wno-missing-field-initializers \
> >          -Wno-unused-result \
> > +        -Wno-logical-not-parentheses \
> >          -Werror=overflow \
> >          -Wdate-time \
> >          -Wnested-externs \
>
> I fixed the -Wno-* detection today. Is this patch still needed? I
> don't have gcc5 here, but I think Daniel fixed most of those warnings
> recently and they turned out to be real bugs. So should I still apply
> it?
>
> Not if it detected real bugs. The warnings I saw did not appear to be
bugs....but perhaps that was the ones in the linux tree and not systemd...

> Thanks
> David
>
> > --
> > 2.2.1.209.g41e5f3a
> >
> > _______________________________________________
> > systemd-devel mailing list
> > systemd-devel at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/systemd-devel
> _______________________________________________
> systemd-devel mailing list
> systemd-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/systemd-devel
>



-- 
Shawn Landden
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20150224/0ee1fb1a/attachment.html>