[systemd-devel] [PATCH] unit: When stopping due to BindsTo=, log which unit caused it

Zbigniew Jędrzejewski-Szmek zbyszek at in.waw.pl
Thu Feb 26 06:44:40 PST 2015


On Tue, Feb 17, 2015 at 01:47:34PM -0500, Colin Walters wrote:
> I'm trying to track down a relatively recent change in systemd
> which broke OSTree; see https://bugzilla.gnome.org/show_bug.cgi?id=743891
> 
> Systemd started to stop sysroot.mount, and this patch should help
> me debug why at least.
> 
> While we're here, "break" on the first unit we find that will
> deactivate, as there's no point in further iteration.
Applied.


>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/src/core/unit.c b/src/core/unit.c
> index ee8e607..c88eca3 100644
> --- a/src/core/unit.c
> +++ b/src/core/unit.c
> @@ -1629,7 +1629,7 @@ static void unit_check_unneeded(Unit *u) {
>  
>  static void unit_check_binds_to(Unit *u) {
>          bool stop = false;
> -        Unit *other;
> +        Unit *other = NULL;
>          Iterator i;
Without this chunk though.

Zbyszek


More information about the systemd-devel mailing list