[systemd-devel] [PATCH] core/mount: only add dependencies to active units for dynamic mounts [was: Re: unit: When stopping due to BindsTo=, log which unit caused it]

[Martin Pitt]

Hey all,

Martin Pitt [2015-02-26 16:50 +0100]:
> IMHO it would be prudent to skip adding the BindsTo= if at the time of
> creating the .mount unit the backing .device unit doesn't actually
> exist. In that case it's a mount which isn't managed by systemd, and
> we shouldn't touch it. We mostly want this BindsTo= for mounts where
> the .device units *do* exist, so that when they go away we can clean
> up the mount (mostly for hotpluggable devices and removable media).

The attached patch does that. It's not really pretty, but it works for
me: mounts in the initramfs are now left alone, and the automatic
unmount of force-ejected media is still working.

Colin, can you please double-check that it works for your CoreOS, too?
If not, I'd appreciate a debug journal.

Thanks,

Martin
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-core-mount-only-add-dependencies-to-active-units-for.patch
Type: text/x-diff
Size: 4959 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20150226/fcf692e8/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20150226/fcf692e8/attachment.sig>