[systemd-devel] [PATCH 3/8] power: refactor the three power management binaries to src/power

[Shawn Landden]

On Thu, Feb 26, 2015 at 6:26 PM, Zbigniew Jędrzejewski-Szmek <
zbyszek at in.waw.pl> wrote:

> I'm not sure we want this... Can you add some justification? Do they share
> code?
>
I found it confusing what parts each of these handled, and some code
sharing is possible, but none is shared currently. This also eliminates one
directory. All of these are handled by units:

sleep.target
shutdown.target
etc...

>
> On Fri, Feb 20, 2015 at 02:31:00PM -0800, Shawn Landden wrote:
> > ---
> >  Makefile.am               |   6 +-
> >  src/core/shutdown.c       | 420
> -----------------------------------------
> >  src/power/Makefile        |  28 +++
> This should be a symlink.
>
> To make all of these symlinks would be a much larger patch, but I can send
such a patch

> >  src/power/shutdown.c      | 420
> +++++++++++++++++++++++++++++++++++++++++
> >  src/power/shutdownd.c     | 461
> ++++++++++++++++++++++++++++++++++++++++++++++
> >  src/power/sleep.c         | 219 ++++++++++++++++++++++
> >  src/shutdownd/Makefile    |   1 -
> >  src/shutdownd/shutdownd.c | 461
> ----------------------------------------------
> >  src/sleep/Makefile        |   1 -
> >  src/sleep/sleep.c         | 219 ----------------------
> >  10 files changed, 1131 insertions(+), 1105 deletions(-)
> >  delete mode 100644 src/core/shutdown.c
> >  create mode 100644 src/power/Makefile
> >  create mode 100644 src/power/shutdown.c
> >  create mode 100644 src/power/shutdownd.c
> >  create mode 100644 src/power/sleep.c
> >  delete mode 120000 src/shutdownd/Makefile
> >  delete mode 100644 src/shutdownd/shutdownd.c
> >  delete mode 120000 src/sleep/Makefile
> >  delete mode 100644 src/sleep/sleep.c
> It's better to use -M for such patches... Make it easier to see what is
> hapenning.
>
> Zbyszek
> _______________________________________________
> systemd-devel mailing list
> systemd-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/systemd-devel
>



-- 
Shawn Landden
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20150227/87a94297/attachment.html>