[systemd-devel] [PATCHv2] core: do not spawn jobs or touch other units during coldplugging

[Ivan Shapovalov]

On 2015-02-27 at 22:25 +0100, Zbigniew Jędrzejewski-Szmek wrote:
> On Wed, Feb 25, 2015 at 09:40:23PM +0300, Ivan Shapovalov wrote:
> > Because the order of coldplugging is not defined, we can reference a
> > not-yet-coldplugged unit and read its state while it has not yet been
> > set to a meaningful value.
> > 
> > This way, already active units may get started again.
> > 
> > We fix this by deferring such actions until all units have been at least
> > somehow coldplugged.
> > 
> > Fixes https://bugs.freedesktop.org/show_bug.cgi?id=88401
> > ---
> > 
> > v2: set waiting state on path/timer units after deferring the actual coldplug,
> >     so that we won't run into the exactly same problem during processing the
> >     deferred entries.
> This looks good. I seems to be the correct thing to do independently of the
> idea to split device states into three with the new pending state.
> Let's see what Lennart thinks though.

Hmm.. This does not relate to the ongoing discussion about adding a
third state for .device units. This is about coldplugging .path
and .timer units during reloads.

-- 
Ivan Shapovalov / intelfx /
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 213 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20150228/b292f1aa/attachment.sig>