[systemd-devel] [PATCH] util: Fix signedness error in lines(), match implementations

Colin Walters walters at verbum.org
Thu Jan 1 12:35:26 PST 2015

On Thu, Jan 1, 2015, at 03:21 PM, Zbigniew Jędrzejewski-Szmek wrote:

> Is there an actual regression? Afaict, your patch does not change
> the behaviour in any way...

I can't think of an actual real world regression.  I could have said
"error introduced by" or something?  It only fixes the case where
the ioctl(fd, TIOCGWINSZ, &ws) fails for some reason - we would
end up thinking the screen had some very large number of lines.

(I only noticed this as I was copying the code)

More information about the systemd-devel mailing list