[systemd-devel] [PATCH v2] Do not clear parent mount flags when setting up namespaces

Topi Miettinen toiwoton at gmail.com
Sat Jan 3 01:05:05 PST 2015


On 01/02/15 21:49, Colin Walters wrote:
> On Thu, Jan 1, 2015, at 03:36 PM, Topi Miettinen wrote:
>> Copy parent directory mount flags when setting up a namespace and
>> don't accidentally clear mount flags later.
> 
> I think unless they're obvious, git commits should at least have a brief rationale for *why* you're making the change, not just *what* the change is.  That way someone later editing the code has an idea what they might break if they changed it.
> 
> Is it something like mounting the tmpfs with options like size=?

It looks like fs specific options do not change when doing the bind
mount. The options that do get cleared unless copied are nosuid, nodev
and noexec flags, maybe also MS_SYNCHRONOUS, MS_POSIXACL etc.

> _______________________________________________
> systemd-devel mailing list
> systemd-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/systemd-devel
> 



More information about the systemd-devel mailing list