[systemd-devel] [PATCH v4] Do not clear parent mount flags when setting up namespaces

[Lennart Poettering]

On Sun, 04.01.15 20:51, Topi Miettinen (toiwoton at gmail.com) wrote:

> When setting up a namespace, mount flags like noexec, nosuid and
> nodev are cleared, so the mounts always have exec, suid and dev
> flags enabled.
> 
> Copy source directory mount flags to target mount when remounting
> the bind mounts.

I don't quite like that we have the set of flags anyway, from the line
we read from /proc/self/mountinfo, but still ask explicity via
statvfs() a second time. Gives this a smell of raciness...

However, /proc/self/mountinfo gives us the flag bits only broken out
as strings, which are nasty to translate back to a flags value, hence
I have merged the patch now.

Thanks!

Lennart

-- 
Lennart Poettering, Red Hat