[systemd-devel] [PATCH] sysv-generator: handle Provides: for non-virtual facility names

[Michael Biebl]

Hi,


2015-01-05 14:35 GMT+01:00 Zbigniew Jędrzejewski-Szmek <zbyszek at in.waw.pl>:
> On Mon, Jan 05, 2015 at 10:30:11AM +0100, Michael Biebl wrote:
>> +        link = strjoin(arg_dest, "/", alias, NULL);
>> +        if (!link)
>> +                return log_oom();
> path_join()?

I borrowed from the existing code in add_symlink(). Will update it to
path_join() if you think this is more suitable.

>
>> +
>> +        r = symlink(service, link);
> Those will be dangling links, no? They will work with current implementation,
> but it would be nicer to create a working symlink.

No, they are not danglink symlinks:

$ head /etc/init.d/networking
#!/bin/sh -e
### BEGIN INIT INFO
# Provides:          networking ifupdown
...

$ ls -al /run/systemd/generator.late/{ifupdown,networking}.service
lrwxrwxrwx 1 root root  18 Jan  5 23:56
/run/systemd/generator.late/ifupdown.service -> networking.service
-rw-r--r-- 1 root root 538 Jan  5 23:56
/run/systemd/generator.late/networking.service


But I'm not quite sure what you mean with "current implementation"?

Michael