[systemd-devel] [PATCH] sysv-generator: avoid wrong orderings for failing units

Zbigniew Jędrzejewski-Szmek zbyszek at in.waw.pl
Wed Jan 7 05:24:14 PST 2015


On Wed, Jan 07, 2015 at 01:44:17PM +0100, Michael Biebl wrote:
> sysv-generator: initialize units before use to ensure correct
>  ordering
> 
> The original loop called fix_order() on each service immediately after
> loading it, but fix_order() would reference other units which were not
> loaded yet.
> This resulted in bogus and unnecessary orderings based on the static
> start priorities.
> 
> Therefore call load_sysv() for every init script when traversing them in
> enumerate_sysv().  This ensures all units are loaded when fix_order() is
> called.
> 
> Bug-Debian: https://bugs.debian.org/771118
> 
> 
> 
> I've updated the commit message accordingly. See attached patch.
Looks fine.

Zbyszek


More information about the systemd-devel mailing list