[systemd-devel] [PATCH 00/11] DHCPv6 address assignment

[Zbigniew Jędrzejewski-Szmek]

On Tue, Jan 13, 2015 at 02:02:10PM +0200, Patrik Flykt wrote:
> 
>       Hi,
> 
> Here is a patch set covering on-link prefix detection and using the prefix
> length information when setting DHCPv6 addresses.
> 
> To be able to have a correct prefix for the IPv6 adresses, the prefixes
> need to be collected in patches 03 and 04. Prefix handling and matching
> happens in patch 07. Patch 08 contains a test case for these.
> 
> ICMPv6 Router Advertisement MTU values are collected in patch 05 with an
> extremely trivial test in patch 06 - basically there to just ensure some
> functionality exists.
> 
> If the prefix information ever expires, patch 09 is there to make it
> possible to fetch the expired one.
> 
> With the help of the revised address iteration functions in patch 02,
> patch 10 fetches the proper prefix length and sets the IPv6 address. The
> patch also attempts to upgrade the IPv6 address prefix length to 128
> should the prefix ever expire, it does so but misses to decrement address
> lifetimes. Something to do for a next patch or two, I guess.
> 
> In addition, patch 01 clears up a forgotten debug printout while patch 11
> fetches DNS and NTP information. Fetching DNS and NTP information have not
> been tested or used yet so proceed with caution or leave patch 11 for later.

I replied to individual patches with some comments. Looks good
in general.

Zbyszek