[systemd-devel] [PATCH] sysv-generator: only allow regular files in enumerate_sysv()

[Colin Guthrie]

Cristian Rodríguez wrote on 14/01/15 13:34:
> El 14/01/15 a las 09:21, Colin Guthrie escribió:
>> If I read the dirent_ensure_type and dirent_is_file code properly, this
>> would mean that symlinks to valid sysvinit scripts are now skipped.
> 
> dirent_is_file() returns true for symlinks.

Jeez, I really failed at reading the code today.... sorry for the noise!

(that said, as a general question what happens in dirent_is_file() if
there is a symlink to a directory?)

Col

-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited http://www.tribalogic.net/
Open Source:
  Mageia Contributor http://www.mageia.org/
  PulseAudio Hacker http://www.pulseaudio.org/
  Trac Hacker http://trac.edgewall.org/