[systemd-devel] [PATCH] cdrom_id: unmount media on --eject-media if media mounted

Kay Sievers kay at vrfy.org
Thu Jan 15 08:18:39 PST 2015


On Thu, Jan 15, 2015 at 5:13 PM, Robert Milasan <rmilasan at suse.com> wrote:
> On Thu, 15 Jan 2015 17:05:54 +0100
> "Lennart Poettering" <lennart at poettering.net> wrote:
>>
>> I think the best way to fix this is in the kernel properly. And if the
>> kernel folks are not willing to do add code for that, then I think
>> it's still better to make sure systemd unmounts it. It can do so
>> asynchronously, simply via the right dependencies. In fact, are you
>> sure that this isn't handled properly yet anyway? The .mount units
>> would just need a BindsTo= on the .device units, and the right thing
>> should happen?
>>
>
> Got no clue, didn't try.
>
> I never said that adding the code to cdrom_id is the best idea, but
> it's an idea. If there are better ways, I prefer them too.

The best idea is probably to start to describe the exact problem. And
adding *why* it is needed to a patch or git subject. The *what* is it
doing is usually pretty easy to find in the changed code, the *why*
isn't.

Kay


More information about the systemd-devel mailing list