[systemd-devel] [PATCH] initial sysv-generator test suite

Martin Pitt martin.pitt at ubuntu.com
Tue Jan 20 08:49:47 PST 2015

Zbigniew Jędrzejewski-Szmek [2015-01-20 16:48 +0100]:
> Maybe we could do this check in configure.ac/Makefile.am (add the test
> to the list conditinally)?

Yes, that's a good idea.

> We already test for python presence and extract the version, so we
> shouldn't duplicate the tests here and have an extra wrapper.

Unfortunately automake's TESTS only accepts single arguments, i. e.
scripts without any arguments. But we need to call $(PYTHON) test/x.py
thus we need an argument.

An alternative would be to add a new

TESTS_PYTHON = test/sysv-generator-test.py test/rule-syntax-check.py

(and perhaps more in the future)

and integrate that into Makefile.am. That would make Makefile.am more
complex, but avoid the extra wrappers.



Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

More information about the systemd-devel mailing list