[systemd-devel] [PATCH] initial sysv-generator test suite
Thomas H.P. Andersen
phomes at gmail.com
Tue Jan 20 14:20:14 PST 2015
On Tue, Jan 20, 2015 at 8:08 PM, Martin Pitt <martin.pitt at ubuntu.com> wrote:
> Hey Jóhann,
> "Jóhann B. Guðmundsson" [2015-01-20 17:55 +0000]:
>> We only provide backwards compatibility with initscript which are lsb
>> compliance and I dont think .<something> ending on a script confirms to
>> that standard hence that test should be unnecessary and that initscript be
>> fixed upstream as in that .<something> ending removed ( or better yet that
>> initscript be migrated )
> But the generator already handles .sh extensions, as they do exist in
> the wild (and being compatible to them is the whole point of the
> generator -- for new things you'd write a proper unit right away).
> It's just missing that .sh extension handling in that particular
> place, and as it's (correctly) doing it in another you get that bug.
Initscripts ending with .sh was indeed a case handled by the
sysv-generator from the beginning. I think that fixing this specific
issue makes sense and the patch (in the other email) looks pretty
simple to me.
Thanks for writing all these tests Martin. The bugs found in the
generator are embarrassing and in hindsight I should have tested this
more thoroughly on a debian system instead of just fedora. I look
forward to all your tests of this. Let me know if I can help out with
extending the test cases or anything.
More information about the systemd-devel