[systemd-devel] [PATCH v2] sysv-generator: Handle .sh suffixes when translating Provides:

[Martin Pitt]

Martin Pitt [2015-01-20 17:44 +0100]:
> the recent fix for sysv-generator's Provides: handling [1] caused, or
> rather uncovered, another bug which now creates symlinks to itself
> "foo.service -> foo.service" for any /etc/init.d/foo.sh.
> 
> The generator would output an error message like
> 
>   Failed to create unit file <path...>/foo.service: File exists
> 
> instead of creating the actual foo.service file. I. e. this completely
> breaks translating init scripts with .sh.

Reworked the patch to apply to current master (where the
sysv-generator test suite now landed), drop the log_debug() leftover,
and clean up the tests.

Note that Michael points out some more problems with the Provides:
alias handling ([1], [2]); I'll work on those next, but this is
already a self-contained and urgent fix, so I think it's good to push.

Thanks,

Martin

[1] https://bugs.debian.org/775265#36
[2] https://bugs.debian.org/775404
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-sysv-generator-Handle-.sh-suffixes-when-translating-.patch
Type: text/x-diff
Size: 4655 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20150121/25dd7a8f/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20150121/25dd7a8f/attachment-0001.sig>