[systemd-devel] [PATCH] sysv-generator: Handle .sh suffixes when translating Provides:

[Michael Biebl]

2015-01-20 17:44 GMT+01:00 Martin Pitt <martin.pitt at ubuntu.com>:
> Hey all,
>
> the recent fix for sysv-generator's Provides: handling [1] caused, or
> rather uncovered, another bug which now creates symlinks to itself
> "foo.service -> foo.service" for any /etc/init.d/foo.sh.
>
> The generator would output an error message like
>
>   Failed to create unit file <path...>/foo.service: File exists
>
> instead of creating the actual foo.service file. I. e. this completely
> breaks translating init scripts with .sh.
>
> Fix with corresponding test case attached. This is a test case for the
> test suite I sent in my previous mail; that might still need some
> masssaging, so if you are ok with this fix, I'll commit that without
> the test case, and add the test case to the suite separately.
>

I think I'd drop the log_debug in sysv_translate_facility(), otherwise
looks good to me.

Thanks for fixing that!

Michael


-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?