[systemd-devel] [PATCH] sysv-generator: Replace Provides: symlinks with real units
martin.pitt at ubuntu.com
Wed Jan 21 08:04:29 PST 2015
Zbigniew Jędrzejewski-Szmek [2015-01-21 16:36 +0100]:
> On Wed, Jan 21, 2015 at 10:46:03AM +0100, Martin Pitt wrote:
> > Keeping track of which alias symlinks we actually want is error prone, and
> > restricting the creation of services for enabled init.d scripts would reduce
> > the utility of the generator (for manual starting disabled init.d scripts) as
> > well as not cover the second case. So if we encounter an existing symlink, just
> > remove it before writing a real unit.
> Looks fine. Although the code is clearer than the description :)
Heh. I removed the above rationale why it isn't done in a different
way, as it might be indeed overcomplicating the commit log.
> > + log_debug("loading SysV script %s", s->path);
> Capital "L"?
> Looks fine from my POV.
Thanks for the review! Pushed.
Martin Pitt | http://www.piware.de
Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)
More information about the systemd-devel