[systemd-devel] [systemd-commits] 5 commits - TODO configure.ac man/systemd.link.xml units/container-getty at .service.m4.in units/systemd-resolved.service.in

Lennart Poettering lennart at poettering.net
Tue Jan 27 10:30:11 PST 2015


On Tue, 27.01.15 19:14, Zbigniew Jędrzejewski-Szmek (zbyszek at in.waw.pl) wrote:

> On Tue, Jan 27, 2015 at 09:30:16AM -0800, Lennart Poettering wrote:
> >  TODO                                 |    6 +++++-
> >  configure.ac                         |    8 +++++---
> >  man/systemd.link.xml                 |   16 +++++++++++-----
> >  units/container-getty at .service.m4.in |    4 ++--
> >  units/systemd-resolved.service.in    |    1 +
> >  5 files changed, 24 insertions(+), 11 deletions(-)
> > 
> > New commits:
> > commit e611755d98ac6b213f39426359c3a94defc6a029
> > Author: Lennart Poettering <lennart at poettering.net>
> > Date:   Tue Jan 27 18:29:33 2015 +0100
> > 
> >     man: mention that 99-default.link is shipped by default, and users hence need to install a lexically earlier .link file for it to be honoured
> 
> What's up with those commit subjects getting longer and longer?  It's
> hard to read, especially when skimming a long list of commit subjects,
> and our tools don't really support this: gitk, file names generated by
> git format patch, cia, git log in a non-terribly-wide window...

Well, gitk reveals the full commit subject when i click on the item.

I mean, that's not worse then if I'd shorten the subject and put the
rest in the body, right? you'd have to click on the thing, to see it
in full..

In general I believe that we don't live in times of 80ch terminals
anymore. Our coding style doesn't suggest breaking lines that early,
and I don't think we should do that either for git commits.

That said, I'll try to keep it shorter,

Lennart

-- 
Lennart Poettering, Red Hat


More information about the systemd-devel mailing list