[systemd-devel] Swap gets activated twice (through fstab and gpt generators)

[Lennart Poettering]

On Fri, 23.01.15 10:18, Martin Pitt (martin.pitt at ubuntu.com) wrote:

> So perhaps the more robust fix would be to make the gpt generator not
> generate swap units if fstab already configures any swap device? I. e.
> auto-discovery and swaps in fstab are mutually exclusive then.

Hmm, so there's something fishy here. systemd should already handle
this nicely, and I thought I tested this successfully.

The logic here is that when we enumerate through /proc/swaps we
already check udev to not only then set the device listed in there to
"active", but also all .swap units that are defined by any of its
symlink names. This means, activating a swap partition should result
in a number of .swap devices to go "active", not just one. THis is
visible if you type "systemctl -a -t swap", which should show a number
of .device units for the same actual swap device...

Now, if two jobs are queued to up a swap device, using different names
for it, like an entry in fstab, and a GPT auto-discovered partition
might do it, then this should mean that one of the jobs should be
removed by the effect of the other, i.e. the later job should be
immediately succeed, since the other job already caused the swap
device to go "active".

There must be a bug somewhere with this... Any chance you can boot in
debug mode and check how the .swap units change states during the
boot, and when the jobs for it are enqueued?

Lennart

-- 
Lennart Poettering, Red Hat