[systemd-devel] [PATCH 06/12] Support cancellation of fsck in progress

[Dimitri John Ledkov]

On 28 January 2015 at 15:31, Zbigniew Jędrzejewski-Szmek
<zbyszek at in.waw.pl> wrote:
> On Wed, Jan 28, 2015 at 03:21:27PM +0000, Dimitri John Ledkov wrote:
>> On 28 January 2015 at 14:53, Zbigniew Jędrzejewski-Szmek
>> <zbyszek at in.waw.pl> wrote:
>> >
>> > On Wed, Jan 28, 2015 at 02:22:54PM +0100, Didier Roche wrote:
>> > >
>> >
>> > > From 104cf82ba28941e907f277a713f834ceb3d909f0 Mon Sep 17 00:00:00 2001
>> > > From: Didier Roche <didrocks at ubuntu.com>
>> > > Date: Mon, 26 Jan 2015 16:40:52 +0100
>> > > Subject: [PATCH 06/12] Support cancellation of fsck in progress
>> > >
>> > > Grab in fsckd plymouth watch key for C or c, and propagate this cancel request
>> > > to systemd-fsck which will terminate fsck.
>> > Could we bind to ^c or if this is not possible, "three c's in three
>> > seconds" instead? I'm worried that before you could press anything to little
>> > effect in plymouth, and now a single key will have significant consequences.
>> >
>>
>>
>> Hm? an interactive message with key-binding is usually shown and then
>> plymouth reacts to such a key prompt.
>> This is how it has always worked on plymouth prompts since forever...
>> thus this would not be a surprise to most plymouth users (~ 5+ years
>> by now?!)
>> Doing it otherwise, will, on the contrary, impede user experience.
> If you say so. I have never interacted with plymouth except to press ESC.
> I'll have to give this a try.

Actually it's not ESC button, but rather any escape sequence will drop
into messages mode. That is shift, ctrl, alt, Fn, all of them.
Thus I don't think ^c binding is actually available to plymouth clients.
But my plymouth knowledge is rusty.

-- 
Regards,

Dimitri.

Intel Corporation (UK) Ltd. - Co. Reg. #1134945 - Pipers Way, Swindon SN3 1RJ.