[systemd-devel] [PATCH] systemd-udevd.service: restore mount propagation

[Lennart Poettering]

On Wed, 28.01.15 14:09, Martin Pitt (martin.pitt at ubuntu.com) wrote:

> Lennart Poettering [2015-01-28 13:33 +0100]:
> > Hmm, yeah, we apparently only add that for file systems listed in
> > /etc/fstab...
> > 
> > If you change the "get_mount_parameters_fragment()" invocation at the
> > beginning of mount_add_device_links() in src/core/mount.c to
> > "get_mount_parameters()", does this make things work for you?
> > 
> > This change might have more effects than just making this work, but I
> > think it's the right thing to do. Could you test please?
> 
> BAZINGA! Thanks for this, now it works perfectly! Now the mount unit
> looks like this:

Applied both patches, but dropped this line:

> +ENV{DISK_MEDIA_CHANGE}=="?*", ENV{ID_CDROM_MEDIA}=="?*", ENV{SYSTEMD_READY}="1"

SYSTEMD_READY=1 is the implied default, hence there's no reason to set
it.

Note that this patch only covers CD driver media sensing. We really
should hanlde SD/CF card readers the same way. Unfortunately however
there's currently no nice property available that we could check for
media with. This would have have to be added to the blkid builtin or
so.

I have now added this to the TODO list. Would be happy to merge a
clean patch!

Lennart

-- 
Lennart Poettering, Red Hat