[systemd-devel] [PATCH 1/2] networkd: accept a trailing '.' on the end of domains

Lennart Poettering lennart at poettering.net
Wed Jan 28 08:49:22 PST 2015

On Thu, 15.01.15 13:24, Michael Marineau (michael.marineau at coreos.com) wrote:

> While not common outside of BIND configs the implied top level '.' in
> domains is commonly accepted and crops up in random places. Starting
> with commit 784d9b9c networkd began validating domains as hostnames
> which rejects trailing dots, breaking short name resolution in some
> environments such as Google Compute Engine. This change splits the
> validation code into two functions to be more tolerant for domains.

Did I get this right? the Google Compute Engine returns a domain name
with trailing dot in the DHCP domain option? 

Our DHCP client should certainly accept that, if that's what people
send, but I am not sure we should be equally liberal for locally
configured bits...

I now made this change: 


Does that make things work on the google thing?


Lennart Poettering, Red Hat

More information about the systemd-devel mailing list