[systemd-devel] [PATCH] loginctl: add rule for qemu's pci-bridge-seat

[David Herrmann]

Hi

On Mon, Jun 29, 2015 at 9:42 AM, Gerd Hoffmann <kraxel at redhat.com> wrote:
> Signed-off-by: Gerd Hoffmann <kraxel at redhat.com>
> ---
>  src/login/71-seat.rules.in | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/src/login/71-seat.rules.in b/src/login/71-seat.rules.in
> index ab7b66f..270da71 100644
> --- a/src/login/71-seat.rules.in
> +++ b/src/login/71-seat.rules.in
> @@ -17,6 +17,12 @@ SUBSYSTEM=="usb", ATTR{bDeviceClass}=="09", TAG+="seat"
>  # 'Plugable' USB hub, sound, network, graphics adapter
>  SUBSYSTEM=="usb", ATTR{idVendor}=="2230", ATTR{idProduct}=="000[13]", ENV{ID_AUTOSEAT}="1"
>
> +# qemu (version 2.4+) has a PCI-PCI bridge (-device pci-bridge-seat)
> +# to group devices belonging to one seat.
> +# see http://git.qemu.org/?p=qemu.git;a=blob;f=docs/multiseat.txt
> +SUBSYSTEM=="pci", ATTR{vendor}=="0x1b36", ATTR{device}=="0x000a", \
> +       TAG+="seat", ENV{ID_AUTOSEAT}="1"
> +

I have no idea why this is correct. Could you provide a proper commit-message?

Is this specific VID/PID match exclusively used for seat'ing? Or might
other pci-bridges use the same (without any intention to get different
seats?). Even if that's the case, I'm still fine with you default, but
please describe this properly so we can understand the implications
later on.

Thanks!
David

>  # Mimo 720, with integrated USB hub, displaylink graphics, and e2i
>  # touchscreen. This device carries no proper VID/PID in the USB hub,
>  # but it does carry good ID data in the graphics component, hence we
> --
> 1.8.3.1
>
> _______________________________________________
> systemd-devel mailing list
> systemd-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/systemd-devel