[systemd-devel] [PATCH] sd-bus: use isempty() consistently

[Daniel Mack]

On 07/20/2015 02:06 PM, Mantas Mikulėnas wrote:
> On Mon, Jul 20, 2015 at 1:14 PM, Daniel Mack <daniel at zonque.org
> <mailto:daniel at zonque.org>> wrote:
> 
>     On 07/19/2015 11:01 AM, Namhyung Kim wrote:
>     > Signed-off-by: Namhyung Kim <namhyung at gmail.com
>     <mailto:namhyung at gmail.com>>
> 
>     Looks good, thanks! However, it does not apply against current master.
>     Care to rebase? Also, we generally prefer GitHub pull requests these
>     days. And you can leave off the Signed-off-by line, we don't use that in
>     the systemd project.
> 
> 
> Does including it hurt though?

We don't use them, so they shouldn't be there. Leaving them around in
some commits but not in others just causes confusion for people reading
the logs.

Everyone with push access usually removes those tags manually.


Thanks,
Daniel