[systemd-devel] [PATCH 0/2] Using XML entities for paths in manpages

Filipe Brandenburger filbranden at google.com
Tue Jun 2 06:50:30 PDT 2015


Hi Daniel,

On Tue, Jun 2, 2015 at 3:04 AM, Daniel Mack <daniel at zonque.org> wrote:
> On 06/02/2015 11:25 AM, Martin Pitt wrote:
>> FTR, this works fine here, using --with-rootprefix= (to avoid the
>> extra slashes). This spawned a long thread and multiple followup
>> patches, and TBH I lost track which patches got proposed and which are
>> superseded; but this one looks good to me. Thank you!
>
> Michael came up with a nicer approach to sanitize all path arguments to
> configure and strip trailing slashes before the Makefile variables are
> substituted. I think we should go for that. I'll collect patches and
> prepare a pull request later.

This is the one patch which does path AX_NORMALIZE_PATH that we're
still missing:
https://github.com/systemd/systemd/commit/d10b3a45b17403ce8a52680703b03888ebee0769

I resent Michael's original patch but including the import of the
latest ax_normalize_path.m4 from autoconf-archive.

I also tested it with a few combinations including --with-rootpath=/
and it worked fine.

I could create a PR in systemd-devs GitHub if you'd like, otherwise
feel free to just push it straight upstream if you prefer.

Cheers,
Filipe


More information about the systemd-devel mailing list