[systemd-devel] [systemd-commits] load-fragment: use UNESCAPE_RELAX flag to parse exec directives

[Filipe Brandenburger]

Pull Request created:
https://github.com/systemd/systemd/pull/44

If you could test it and confirm your "sudo" case with \073 works now,
and your regexp case isn't broken, I'd appreciate it.

Cheers,
Filipe


On Tue, Jun 2, 2015 at 2:53 PM, Filipe Brandenburger
<filbranden at google.com> wrote:
> Hi Michael,
>
> On Tue, Jun 2, 2015 at 2:50 PM, Michael Biebl <mbiebl at gmail.com> wrote:
>> 2015-06-02 12:55 GMT+02:00 Daniel Mack <daniel at zonque.org>:
>>> So, my primary motivation was to fix the obvious regression at hand
>>> first, but I agree the actual problem goes deeper.
>>
>> Looks like even with this patch applied, we have regressions compared
>> to previous releases.
>> See https://bugs.freedesktop.org/show_bug.cgi?id=90794#c4
>
> So that looks like a \073 being turned into, well, "\\073", instead of
> turning into ";".
>
> This is actually fixed in my latest patch that uses unquote_first_word.
>
> I still want to run some additional tests on it and add some extra use
> cases, but that use case for \073 is already there and was actually
> the one I had to "fix" to do ; instead.
>
> I expect to be able to send this patch out later today or early tomorrow.
>
> Cheers,
> Filipe