[systemd-devel] [ANNOUNCE] Git development moved to github

[David Herrmann]

Hi

On Wed, Jun 3, 2015 at 7:48 PM, Lucas De Marchi
<lucas.de.marchi at gmail.com> wrote:
> Of course this is a non-issue for several projects in github which
> don't have proper commit
> review. It's not the case of systemd and it seems it's even the reason
> why you are moving
> to github.  So I'm just curious if anything changed in this regard or
> you solved it in another
> way.

github attaches code-reviews to the actual git commits. The PR
displays all comments on the commits in the given branch. As long as
those commits stay part of the PR, the comments will remain. However,
if people force-push corrected commits, the old commits are no longer
linked in any way to the PR and thus will not be shown. You can still
access them by directly looking at the old commit, though.

With their model, I understand why old reviews are lost on force-push.
You can work around this, by including the sha256 in your PR comments
after a review. Those comments remain and you can look at the old
reviews this way. They'll not be linked in a shiny way (but that's the
same if you resend your mails on an ML..).

Thanks
David