[systemd-devel] [ANNOUNCE] Git development moved to github

[Alban Crequy]

On Tue, Jun 9, 2015 at 11:37 PM, Lennart Poettering
<lennart at poettering.net> wrote:
> On Tue, 09.06.15 13:04, Filipe Brandenburger (filbranden at google.com) wrote:
>
>> On Tue, Jun 9, 2015 at 12:59 PM, Lennart Poettering
>> <lennart at poettering.net> wrote:
>> > [...] so we comment and ask for a new PR, and close the old one.
>>
>> See my previous comment, I think this "cure" is worse than the
>> "disease" :-)
>
> Why would you say this? Why are multiple sequencial PR, where the old
> obsoleted ones are closed and locked that bad?
>
>> Instead, just reuse the same PR and use `git push -f` to ship new
>> versions of the commits to the same branch... Yes it's awful but
>> unfortunately that's how GitHub works...
>
> Yeah, it is awful, and loses all the comments, as well is incompatible
> with having multiple people making patch suggestions for the same
> issue.

FWIW it only loses the comments if people comment on individual
commits instead of commenting on the "Files changed" tab of a PR. I
usually comment in this way on purpose instead of commenting on
commits, so that the history of comments are kept in the PR, even
after rebase (it might be folded if the chunk of the patch is not
there anymore, but the comment is still in the PR). If you really want
to comment on an individual commit (but I don't recommend it), you can
include the reference of the PR in your comment (#42), then github
will keep your comment attached to the PR.

I think it is fine as it is as long as people comment in the "Files
changed" tab.

>> To work around the problem of line comments being lost, just ask
>> *reviewers* to make most of the relevant comments in the PR thread and
>> keep line comments to simple comments that are probably not going to
>> be relevant when they're obliterated...
>
> Well, *the* major reason we switched to github is actually taking
> benefit of the much more powerful inline review tool that's a pleasure
> to work with. Reviews by mail are just awful, and reviews out-of-line
> are even worse.
>
> Lennart
>
> --
> Lennart Poettering, Red Hat
> _______________________________________________
> systemd-devel mailing list
> systemd-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/systemd-devel