[systemd-devel] [PATCH v4] watchdog: Don't require WDIOC_SETOPTIONS/WDIOS_ENABLECARD

[Jean Delvare]

On Wed, 17 Jun 2015 19:04:34 +0200, Lennart Poettering wrote:
> On Wed, 17.06.15 18:57, Jean Delvare (jdelvare at suse.de) wrote:
> 
> > Not all watchdog drivers implement WDIOC_SETOPTIONS. Drivers which do
> > not implement it have their device always enabled. So it's fine to
> > report an error if WDIOS_DISABLECARD is passed and the ioctl is not
> > implemented, however failing when WDIOS_ENABLECARD is passed and the
> > ioctl is not implemented is not good: if the device was already
> > enabled then WDIOS_ENABLECARD was a no-op and wasn't needed in the
> > first place. So we can just ignore the error and continue.
> 
> Thanks! Applied!

Thank you very much for the reviews and your patience.

-- 
Jean Delvare
SUSE L3 Support