[systemd-devel] [PATCH] tmpfiles: Fix handling of duplicate lines [was: Regression in 219: tmpfiles.d order not respected any more]

[Martin Pitt]

Hey Zbigniew, all,

Martin Pitt [2015-03-05 10:20 +0100]:
> As per tmpfiles.d(5), the first match should win if there are several
> tmpfiles.d lines for the same directory. Our rsyslog package ships a
> /usr/lib/tmpfiles.d/00rsyslog.conf which sets /var/log to 0775, so
> that it can write into it as the "syslog" system user. But now the
> permissions of /var/log are 0755 as /usr/lib/tmpfiles.d/var.conf
> overwrites it.

The attached patch helps and generally seems to behave fine. But I'd
really like Zbigniew to review/ack this, I'm not entirely sure whether
aborting on the first match is actually correct, or whether we need to
look at the other items in the array still for some reason.

Thanks,

Martin
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-tmpfiles-Fix-handling-of-duplicate-lines.patch
Type: text/x-diff
Size: 1326 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20150305/6f31862f/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20150305/6f31862f/attachment.sig>