[systemd-devel] [systemd-commits] 9 commits - configure.ac .gitignore Makefile.am Makefile-man.am man/systemd-fsckd.service.xml man/systemd-fsck at .service.xml po/de.po po/el.po po/fr.po po/hu.po po/it.po po/pl.po po/POTFILES.in po/pt_BR.po po/ru.po po/sv.po po/uk.po src/fsck src/fsckd src/shared test/mocks units/.gitignore units/systemd-fsckd.service.in units/systemd-fsckd.socket units/systemd-fsck-root.service.in units/systemd-fsck at .service.in
lennart at poettering.net
Tue Mar 10 03:49:05 PDT 2015
On Tue, 10.03.15 08:21, Martin Pitt (martin.pitt at ubuntu.com) wrote:
> > Please, be more careful with complex code like this, this needs more
> > rounds of review before something like this can be merged...
> Okay. It went through 4 rounds of review on the ML and several folks
> commented, there were no more outstanding/unaddressed review comments,
> and it seemed to me that we had consensus on IRC to land this now.
> Procedurally, what should I/we do next time before landing such large
> patches? Wait for an explicit ack on the ML from you?
Well, if it's complex code like this, get Zbigniew or Kay or Tom or so
to say it's OK...
I mean, I actually *do* appreciate that you don't ask for every patch
to be reviewed on the ML, to keep the traffic minimal. In this case I
would simply have preferred more rounds than usual, since it's not
> Thanks and sorry for the hassle,
Lennart Poettering, Red Hat
More information about the systemd-devel