[systemd-devel] [PATCH] path_is_mount_point: handle false positive on some fs

Karel Zak kzak at redhat.com
Wed Mar 11 03:44:50 PDT 2015


On Tue, Mar 10, 2015 at 04:53:38PM +0100, Lennart Poettering wrote:
> Note that the st_dev thing is the traditional way to detect whether
> one crosses a file system boundary. It's used for this by tools like
> cp, find, .... We slightly enhance this by using name_to_handle_at(),
> so that we can also detect bind mounts from file systems onto
> themselves. Now, if overlayfs breaks the same file system logic of all
> other tools, I am not convinced that systemd should not be broken by
> it too.. It sounds surprising that we should work around this in
> systemd, but not in all other tools. 
> 
> Or to turn this around: instead of patching systemd the better idea
> would probably be to teach overlayfs name_to_handle_at() support, so

 +1

-- 
 Karel Zak  <kzak at redhat.com>
 http://karelzak.blogspot.com


More information about the systemd-devel mailing list