[systemd-devel] [PATCH] shutdown: add kexec loading, avoid calling `kexec` binary unnessecarily

Kay Sievers kay at vrfy.org
Wed Mar 11 18:16:17 PDT 2015


On Thu, Mar 12, 2015 at 2:12 AM, Shawn Landden <shawn at churchofgit.com> wrote:
> On Wed, Mar 11, 2015 at 5:51 PM, Kay Sievers <kay at vrfy.org> wrote:
>>
>> On Thu, Mar 12, 2015 at 1:22 AM, Shawn Landden <shawn at churchofgit.com>
>> wrote:
>> > Still use helper when Xen Dom0, to avoid duplicating some hairy code.
>> >
>> > I think the rbtree version was far more understandable as
>> > greedy_realloc0()
>> > is very messy to do correctly.
>> >
>> > Take fopenat() from lsof.
>> > Add opendirat()
>>
>> We have that in util.c :: xopendirat()
>>
>> > Future: generate BootLoaderSpec files for other kernel install locations
>>
>> This approach duplicates, the potentially complex, boot manager kernel
>> selection logic.
>>
>
> Hopefully it could be unified in some way. I find it disturbing that systemd
> will have a great deal of EFI-specific code.

Well, I find it a lot more disturbing that we "want" kexec, which is
in many cases just a pretty dirty short-cut for a reboot. And we need
to teach that short-cut all sorts of logic and more dirty tricks is
has no business with, just to be able to do its short-cutting. :)

Kay


More information about the systemd-devel mailing list