[systemd-devel] [PATCH] core: don't change removed devices to state "tentative" [was: Re: [PATCH] unit: When stopping due to BindsTo=, log which unit caused it]

[Martin Pitt]

Hello all,

Martin Pitt [2015-03-01 12:43 +0100]:
> Lennart Poettering [2015-02-28 17:40 +0100]:
> > This is implemented now. Please check if this fixes this issue for
> > you.
> 
> This fixes the bad unmounts at boot, but also breaks the automatic cleanup of
> stale mounts after CD ejection.
> [...]
> but after ejecting the mount still stays around. The device unit does
> to activating/tentative, and the .mount unit is unchanged from the above.
> Supposedly this line is the interesting one:
> 
>   systemd[1]: dev-sr1.device changed plugged -> tentative
> 
> which in this case really should become "dead". The full debug journal
> is at http://people.canonical.com/~pitti/tmp/journal-cd-eject.txt

The attached patch fixes that. I tested CD ejection, the cleanup
unmount works properly again. I also verified that mounts done in the
initramfs (i. e. "tentative" device state) are still kept around
without unmounting them.

Thanks,

Martin
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-core-don-t-change-removed-devices-to-state-tentative.patch
Type: text/x-diff
Size: 1451 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20150313/2389ec72/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20150313/2389ec72/attachment.sig>