[systemd-devel] [PATCH 3/4] Update the man page of tmpfiles.d(5), to document the new h/H command.

[Zbigniew Jędrzejewski-Szmek]

On Tue, Mar 10, 2015 at 09:07:42PM +0100, Goffredo Baroncelli wrote:
> Update the man page of tmpfiles.d(5), to document the new h/H command.
> ---
>  man/tmpfiles.d.xml | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
> 
> diff --git a/man/tmpfiles.d.xml b/man/tmpfiles.d.xml
> index 8815bf9..469deeb 100644
> --- a/man/tmpfiles.d.xml
> +++ b/man/tmpfiles.d.xml
> @@ -303,6 +303,37 @@
>          </varlistentry>
>  
>          <varlistentry>
> +          <term><varname>h</varname></term>
> +          <listitem><para>Set file/directory attributes. Lines of this type
> +          accept shell-style globs in place of normal path names.</para>
> +
> +          <para>The format of the argument field is <varname>[+-=][aAcCdDeijsStTu]
> +          </varname></para>
> +
> +          <para>The prefix <varname>+</varname> causes the
> +          attribute(s) to be added; <varname>-</varname> causes the
> +          attribute(s) to be removed; <varname>=</varname>
> +          causes the attributes to set exactly as the following letters.</para>
What happens if neither of the three prefix lettes is used? This
should be documented.

> +          <para>The letters 'aAcCdDeijsStTu' select the new
<literal> instead of ''.

> +          attributes for the files, see
> +          <citerefentry><refentrytitle>chattr</refentrytitle>
> +          <manvolnum>1</manvolnum></citerefentry> for further information.
> +          </para>
> +          <para>Passing only <varname>=</varname> as argument,
> +          reset all the file attributes.</para>
resets

So, is this description accurate? Operations on the attributes are
explicitly limited to the ones corresponding to the letters above (by
using a mask). But files can have other attributes, and the kernel might
define new attributes as some point. So maybe add a sentence like
"When operating on attributes, system-tmpfiles limits itself to the
attributes corresponding to the letters listed above. All other attributes
will be left untouched, even with <literal>=</literal>."

Zbyszek

> +
> +          </listitem>
> +        </varlistentry>
> +
> +        <varlistentry>
> +          <term><varname>H</varname></term>
> +          <listitem><para>Recursively set file/directory attributes. Lines
> +          of this type accept shell-style globs in place of normal
> +          path names.
> +          </para></listitem>
> +        </varlistentry>
> +
> +        <varlistentry>
>            <term><varname>a</varname></term>
>            <term><varname>a+</varname></term>
>            <listitem><para>Set POSIX ACLs (access control lists). If
> @@ -529,6 +560,7 @@
>        <citerefentry project='man-pages'><refentrytitle>setfattr</refentrytitle><manvolnum>1</manvolnum></citerefentry>,
>        <citerefentry project='man-pages'><refentrytitle>setfacl</refentrytitle><manvolnum>1</manvolnum></citerefentry>,
>        <citerefentry project='man-pages'><refentrytitle>getfacl</refentrytitle><manvolnum>1</manvolnum></citerefentry>
> +      <citerefentry project='man-pages'><refentrytitle>chattr</refentrytitle><manvolnum>1</manvolnum></citerefentry>
>      </para>
>    </refsect1>
>  
> -- 
> 2.1.4
> 
> _______________________________________________
> systemd-devel mailing list
> systemd-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/systemd-devel