[systemd-devel] [PATCH] resolved: Do not add .busname dependencies, when compiling without kdbus.

[David Herrmann]

Hi

On Thu, Mar 19, 2015 at 4:59 PM, Michael Biebl <mbiebl at gmail.com> wrote:
> 2015-03-19 15:02 GMT+01:00 Dimitri John Ledkov <dimitri.j.ledkov at intel.com>:
>> On 19 March 2015 at 13:31, David Herrmann <dh.herrmann at gmail.com> wrote:
>>> Hi
>>>
>>> On Tue, Mar 17, 2015 at 4:37 PM, Dimitri John Ledkov
>>> <dimitri.j.ledkov at intel.com> wrote:
>>>> ---
>>>>  Makefile.am                          |  2 +-
>>>>  units/systemd-resolved.service.in    | 29 -----------------------------
>>>>  units/systemd-resolved.service.m4.in | 31 +++++++++++++++++++++++++++++++
>>>>  3 files changed, 32 insertions(+), 30 deletions(-)
>>>>  delete mode 100644 units/systemd-resolved.service.in
>>>>  create mode 100644 units/systemd-resolved.service.m4.in
>>>
>>> There is already a:
>>>     ConditionPathExists=/sys/fs/kdbus/0-system/
>>> in the busname unit. Isn't that enough?
>>>
>>
>> The busname unit is not installed, when compiling without kdbus. Thus
>> upon loading systemd-resolved.service, .busname unit is attempted to
>> be loaded and ends up being "not found", which imho is untidy.
>>
>
> This also leads to those error messages in the journal:
>
> Mär 19 16:57:59 debian systemd[1]: Cannot add dependency job for unit
> org.freedesktop.resolve1.busname, ignoring: Unit
> org.freedesktop.resolve1.busname failed to load: No such file or
> directory.
>
> So, +1 for Dimitri's patch. Looks correct to me.
> Unless someone objects, I'm planning on merging it.

Yes, please go ahead. I missed that .busname is not installed without
--enable-kdbus.

Thanks
David