[systemd-devel] [PATCH] hwdb: ship ids-update.pl & sdio.ids in the release tarballs.

[Zbigniew Jędrzejewski-Szmek]

On Fri, Mar 20, 2015 at 07:02:48AM +0100, Michael Biebl wrote:
> 2015-03-20 6:40 GMT+01:00 Marcel Holtmann <marcel at holtmann.org>:
> > Hi Michael,
> >
> >>>>>>>>> On 16 March 2015 at 23:15, Marcel Holtmann <marcel at holtmann.org> wrote:
> >>>>>>>>>> Hi Dimitri,
> >>
> >>>>>> Just tell patch or git to skip the hunks modifying ids-update.pl and sdio.ids. Problem solved.
> >>>>>
> >>>>> I'll apply the patch, but with a slightly different motivation.
> >>>>>
> >>>>> [L]GPL requires commercial entities distributing a modified version of
> >>>>> the program to provide full source in the preferred form for modification,
> >>>>> including all scripts used for building. This includes sdio.ids and
> >>>>> ids-update.pl. We should make it easy to follow the our licensing, so
> >>>>> we should include those files in our tarball to make it directly
> >>>>> redistributable.
> >>>>
> >>>> that is just making stuff up.
> >>> Where was I wrong?
> >>>
> >>>> Are you now also including usb.ids?
> >>> We probably should
> >>>
> >>
> >> Right, we should include all source files, not only the generated files.
> >
> > is this turning in Freaky Friday now? Can we please be real for a bit.
> >
> > You do realize that I did not put a copyright header on top of sdio.ids. In addition this information will be most likely considered a not copyrightable piece of source anyway. If we assume that this is non-copyrightable, then how can you apply a copyleft license to it?

It's not about applying a license to sdio.ids. If may just as well be
non-copyrightable. It's just distributed because in the tarball because
it is one of the things necessary to generate a patch.

Now, in practice, any sane person would clone the repository and do
modifications there, but the terms of our license demand that
redistributors redistribute the source. I think it makes sense to
set things up so that if they just use the tarball, they actually
are doing that.

Zbyszek

> Are you saying https://pci-ids.ucw.cz/v2.2/pci.ids is wrong in adding
> a license header?
>
> What is the preferred form of modification? The hwdb files or the .ids
> files? Where do users add new entries: to the hwdb files or the .ids
> files?