[systemd-devel] [PATCH] CODING_STYLE: this also help with unaligned memory accesses

Lennart Poettering lennart at poettering.net
Thu Mar 26 01:31:17 PDT 2015


On Tue, 24.03.15 11:16, Shawn Landden (shawn at churchofgit.com) wrote:

> And those arches don't get much testing too.
> ---
>  CODING_STYLE | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/CODING_STYLE b/CODING_STYLE
> index b687e72..8934954 100644
> --- a/CODING_STYLE
> +++ b/CODING_STYLE
> @@ -14,7 +14,8 @@
>  - The destructors always unregister the object from the next bigger
>    object, not the other way around
>  
> -- To minimize strict aliasing violations, we prefer unions over casting
> +- To minimize strict aliasing violations and unaligned memory accesses,
> +  we prefer unions over casting

Unaligned memory accesses are an orthogonal problem really. I don't
see how the change above really makes sense?

Lennart

-- 
Lennart Poettering, Red Hat


More information about the systemd-devel mailing list