[systemd-devel] [PATCH 1/5] shared/import-util: tag renamed to reference to support v2 pull by digest

[Lennart Poettering]

On Thu, 07.05.15 17:47, Pavel Odvody (podvody at redhat.com) wrote:

> Signed-off-by: Pavel Odvody <podvody at redhat.com>

We dont do S-o-b in systemd.

> ---
>  src/shared/import-util.c | 19 +++++++++++++++++++
>  src/shared/import-util.h |  1 +
>  2 files changed, 20 insertions(+)
> 
> diff --git a/src/shared/import-util.c b/src/shared/import-util.c
> index 660d92a..f2fb6d0 100644
> --- a/src/shared/import-util.c
> +++ b/src/shared/import-util.c
> @@ -150,6 +150,25 @@ int raw_strip_suffixes(const char *p, char **ret) {
>          return 0;
>  }
>  
> +bool dkr_ref_is_valid(const char *ref) {
> +        const char *colon;
> +
> +        if (isempty(ref))
> +                return false;
> +
> +        colon = strchr(ref, ':');
> +        if (!colon)
> +                return filename_is_valid(ref);
> +
> +        else if (!startswith(ref, "sha256"))
> +                return false;
> +
> +        else if (!in_charset(colon + 1, "0123456789abcdef"))
> +                return false;


Hmm, how precisely do this refs look, can you provide some examples?

Right now you do not validate anything between "sha256" and the first
":", that's not intended, is it?

Lennart

-- 
Lennart Poettering, Red Hat