[systemd-devel] [PATCH 1/3] core: Add LISTEN_NAMES environment variable

[Zbigniew Jędrzejewski-Szmek]

On Fri, May 15, 2015 at 05:35:48PM +0200, Lennart Poettering wrote:
> On Fri, 15.05.15 17:09, Krzysztof Opasiak (k.opasiak at samsung.com) wrote:
> 
> > When passing file descriptors to service systemd
> > pass also two environment variable:
> > - LISTEN_PID - PID of service
> > - LISTEN_FDS - Number of file descriptors passed to service
> > 
> > Passed fds may have different types: socket, fifo etc.
> > To distinguish them sd-daemon library provides a set of
> > sd_is_*() functions which does stat on given fd and path
> > and check if this fd is relaten with this path.
> > 
> > This commit adds third environment variable:
> > - LISTEN_NAMES - paths/addresses of passed fds
> > 
> > this variable consist of fds names separated by :.
> > Each fd name consist of two parts:
> > fd_type=fd_address
> 
> Why do we need the type at all? It can always be derived from the fd
> anyway, so why specify?

Why it the motivation? Patch description talks tabout passing the
path/address in LISTEN_NAMES. Isn't this something that can be queried
already? TODO talks about "identifiers". Is "identifier" the same thing,
or did the TODO item about have some different meaning?

Zbyszek