[systemd-devel] [systemd-commits] src/shared TODO

Zbigniew Jędrzejewski-Szmek zbyszek at in.waw.pl
Sat May 16 15:11:20 PDT 2015


On Fri, May 15, 2015 at 05:08:12PM +0200, Lennart Poettering wrote:
> B1;3802;0cOn Sun, 10.05.15 10:18, Zbigniew Jędrzejewski-Szmek (zbyszek at kemper.freedesktop.org) wrote:
> 
> > +
> > +        fflush(f);
> > +        if (ferror(f))
> > +                return log_error_errno(errno, "Failed to write unit file %s: %m", unit);
> 
> Small note: please use fflush_and_check() for cases like this, it
> makes this a bit shorter and safer...
OK.

> (I changed this in git now)
I changed a few more places now.

Zbyszek


More information about the systemd-devel mailing list