[systemd-devel] [PATCH v3] device: Fix overzealous unmounting of tentative device mounts

Lennart Poettering lennart at poettering.net
Tue May 19 08:23:39 PDT 2015

On Tue, 19.05.15 16:05, Martin Pitt (martin.pitt at ubuntu.com) wrote:

> That was a red herring. Turns out that your patch only added devices
> to "around" which had "mount->just_mounted || mount->just_changed",
> which is obviously not the case for mounts which have been around for
> a while (and these are the ones we need to keep!). This patch fixes
> that; although I'm unsure yet whether we *also* need to record the ones
> with "mount->just_mounted || mount->just_changed"; my gut feeling says
> yes, and we need to restructure this a bit to run the set_put(around, ...)
> for all mount->is_mounted Mount units. WDYT?

Yes, we need to also record those which were just mounted or changed,
in case systemd rereads /proc/self/mountinfo at a time where two
mounts where created at once from the same device.

I now committed a change to implement that, can you check if this
fixes the issue for you?



Lennart Poettering, Red Hat

More information about the systemd-devel mailing list