[systemd-devel] systemd-218 - Requisite implies TriggeredByRestartOf

[Lennart Poettering]

On Tue, 19.05.15 14:15, Uoti Urpala (uoti.urpala at pp1.inet.fi) wrote:

> On Tue, 2015-05-19 at 01:26 +0200, Lennart Poettering wrote:
> > On Tue, 19.05.15 00:55, Lennart Poettering (lennart at poettering.net) wrote:
> > > On Thu, 14.05.15 21:23, Evert (evert.gentoo at planet.nl) wrote:
> > > > According to the systemd documentation, Requisite disallows starting a
> > > > unit unless the specified unit has been started. This seems to work
> > > > fine, however, if the specified unit has been restarted, this unit will
> > > > be started too!
> > > > This is not what should happen and it doesn't happen with a stop and
> > > > start of the specified unit, so clearly, restart behaves different than
> > > > stop followed by start.
> 
> > > "systemctl stop" by the user. Now, as a special shortcut we currently map
> > > "Requisite=" and "Required=" to a reverse dependency of
> > > "RequiredBy=", which is problematichere, since we'll hence make no
> > > distinction between the two when processing "systemctl stop".
> > > 
> > > I figure we need to split up the reverse dep here, and introduce a
> > > seperate RequisiteBy= dependency so that we can avoid this problem...
> > 
> > Fixed in git. Please verify.
> 
> I think you're talking about something quite different than the problem
> described by Evert. The bug report was about a currently stopped
> depending unit being started by actions on a depended-on unit, which is
> equally wrong for either "Requires=" or "Requisite=", and is no reason
> for adding any new distinction between them! And the problem was also
> about "systemctl restart", while "systemctl stop" worked as expected.
> 
> Did your change disable propagation of STOP from depended-on unit to the
> one using "Requisite="? If so, I think that's wrong and should be
> reverted - the documentation says Requisite is "similar to Requires=",
> and gives no reason to expect that propagation in the direction from the
> depended-on unit to the depending-on unit would be affected.

I have now reverted this with
a1036fd1b0c195a63c983db67024d4b725f0166c. Please check.

Lennart

-- 
Lennart Poettering, Red Hat