[systemd-devel] [PATCH v2 0/5] systemd-importd - support for pulling from V2 Dkr registries

[Lennart Poettering]

On Tue, 19.05.15 16:29, Pavel Odvody (podvody at redhat.com) wrote:

Looks good! Applied all five! Good work!

> Hey,
> 
> this is the new patch set with incorporated changes from the review:
> - stricter digest validation
> - got rid of the additional http headers/#defines
>   - all data now derived from --dkr-index-url value
> - json_variant renamed to JsonVariant
> - JsonVariantType enum is now a typedef
> - enum PullStrategy now properly typedef'd and named DkrPullVersion
> - structure of the JSON document is now thoroughly checked in the tests
> - minor memory allocation/initialization changes
> - commit messages were made more specific (added clarification for the DOM-like parser)
> 
> Pavel Odvody (5):
>   shared/import-util: Tag renamed to reference
>   shared/json: Added DOM-like JSON parser
>   test/test-json: Tests for the tokenizer bugfix and the DOM parser
>   import/pull: Tag replaced with reference
>   import/pull-dkr: V2 image specification and manifest support
> 
>  src/import/pull-dkr.c    | 542 ++++++++++++++++++++++++++++++++++++++++++-----
>  src/import/pull-dkr.h    |   3 +-
>  src/import/pull.c        |  28 ++-
>  src/shared/import-util.c |  21 ++
>  src/shared/import-util.h |   2 +
>  src/shared/json.c        | 432 ++++++++++++++++++++++++++++++++++++-
>  src/shared/json.h        |  37 ++++
>  src/test/test-json.c     |  97 +++++++++
>  8 files changed, 1087 insertions(+), 75 deletions(-)
> 
> -- 
> 2.1.0
> 
> 



> _______________________________________________
> systemd-devel mailing list
> systemd-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/systemd-devel



Lennart

-- 
Lennart Poettering, Red Hat