[systemd-devel] [PATCH] buildsys: remove always true autoconf checks

[Lennart Poettering]

On Tue, 19.05.15 20:17, Cristian Rodríguez (crrodriguez at opensuse.org) wrote:

> All this checks are always true in any modernish linux system.
> ---
>  configure.ac | 11 -----------
>  1 file changed, 11 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 3efee22..cd6375b 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1293,17 +1293,6 @@ AC_CHECK_HEADERS_ONCE([valgrind/memcheck.h valgrind/valgrind.h])
>  have_myhostname=no
>  AC_ARG_ENABLE(myhostname, AS_HELP_STRING([--disable-myhostname], [disable nss-myhostname support]))
>  if test "x$enable_myhostname" != "xno"; then
> -        AC_HEADER_STDC
> -        AC_CHECK_HEADERS([arpa/inet.h fcntl.h inttypes.h netdb.h
> netinet/in.h stdlib.h string.h sys/socket.h sys/time.h unistd.h
> nss.h sys/ioctl.h sys/auxv.h])

sys/auxv.h at least is a relatively recent addition to glibc, hence
simply removing this all appears too broad...

Not sure however why this is in the enable_myhostname part however, it
should just be moved up. Could you prep a patch that does that?

> -
> -        AC_C_CONST
> -        AC_TYPE_SIZE_T
> -        AC_HEADER_TIME
> -
> -        AC_FUNC_MALLOC
> -        AC_FUNC_SELECT_ARGTYPES
> -        AC_CHECK_FUNCS([gethostbyaddr gethostbyname gettimeofday inet_ntoa memset select socket strcspn strdup strerror strncasecmp strcasecmp strspn])
> -
>          have_myhostname=yes
>  fi
>  AM_CONDITIONAL(HAVE_MYHOSTNAME, [test "$have_myhostname" = "yes"])
> -- 
> 2.4.1
> 
> _______________________________________________
> systemd-devel mailing list
> systemd-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/systemd-devel


Lennart

-- 
Lennart Poettering, Red Hat