[systemd-devel] [PATCH v2 1/2] systemctl: drop hardcoded chkconfig invocation

[Lukáš Nykrýn]

Lennart Poettering píše v Čt 28. 05. 2015 v 13:05 +0200:
> On Wed, 27.05.15 18:08, Martin Pitt (martin.pitt at ubuntu.com) wrote:
> 
> > Hello again,
> > 
> > as discussed previously this second variant of un-hardcoding chkconfig
> > now uses the proposed /usr/lib/systemd/systemd-sysv-install
> > abstraction.
> > 
> > I also added a reference implementation for chkconfig which gets
> > installed with --enable-chkconfig, so on Fedora this should be no
> > net change.
> 
> Nah, please remove this part. We should not ship that upstream. THis
> is something that Fedora's initscripts.rpm should provide eventually,
> and should be neither shipped with systemd upstream nor systemd.rpm in
> Fedora.

+1
I will patch chkconfig to handle this similarly as the install_initd.

> 
> > This doesn't have a manpage yet (as it's not an user-callable
> > program); where should this be documented? Just adding to README?
> 
> Well, you could put it on some fdo wiki page maybe and link this up
> from the source and from NEWS.
> 
> Doesn't have to be too formal...
> 
> Patch looks fine otherwise: just remove any trace of chkconfig.
> 
> Lennart
>